Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-7918] Add more cleanups for user credentials #66

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Extends sensitive url filtering:

  • filters GITHUB_SERVER_URL env variable
  • filters credentials from SSH urls

Motivation
New datadog-ci-specs are ready to be released

How to test the change?
Unit tests only

@anmarchenko anmarchenko changed the title Anmarchenko/ssh_credentials_cleanup Add more cleanups for user credentials Nov 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #66 (478ce78) into main (ef6e234) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   99.16%   99.17%           
=======================================
  Files         106      107    +1     
  Lines        3606     3616   +10     
  Branches      131      132    +1     
=======================================
+ Hits         3576     3586   +10     
  Misses         30       30           
Files Coverage Δ
lib/datadog/ci/ext/environment/extractor.rb 100.00% <100.00%> (ø)
...dog/ci/ext/environment/providers/github_actions.rb 100.00% <100.00%> (ø)
lib/datadog/ci/utils/url.rb 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@anmarchenko anmarchenko changed the title Add more cleanups for user credentials [CIVIS-7918] Add more cleanups for user credentials Nov 10, 2023
@anmarchenko anmarchenko merged commit 7c6106a into main Nov 10, 2023
11 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/ssh_credentials_cleanup branch November 10, 2023 11:22
@github-actions github-actions bot added this to the 0.4.0 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants