-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dep] Upgrade axios from 0.21.4 to 1.6.0 #1108
Conversation
This bug lead to a silent error, with a `Decoder has partially decoded field` warning in our backend. Maybe the boundary was incorrect. This bug gets fixed with form-data/form-data@v3.0.1...v4.0.0 I also tried with `axios@1.6.1`, but it didn't work.
Datadog ReportBranch report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Still curious about the standalone jest config.
{ | ||
tsconfig: 'tsconfig.json', | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a moment I thought it was related to the first issue I had with axios (see this job):
Turns out it was really just a warning, but it's still a good thing to fix 😄
* [dep] Upgrade axios from `0.21.4` to `1.6.0` * Fix jest config * Fix axios in standalone binary * Fix bug when sending FormData This bug lead to a silent error, with a `Decoder has partially decoded field` warning in our backend. Maybe the boundary was incorrect. This bug gets fixed with form-data/form-data@v3.0.1...v4.0.0 I also tried with `axios@1.6.1`, but it didn't work. * Do not return early in `formatBackendErrors`
What and why?
Closes #1096
Bumping
axios
to1.6.0
came with 2 issues:FormData
(which sendsmultipart/form-data
payloads) was failing silently in our backend with only a warning.Decoder has partially decoded field
, which was probably caused by an incorrect boundary. Bumpingform-data
from3.0.1
to4.0.0
(compare changes) solved the issue: 41ce71bjunit upload
command. I ensured this command also works with the standalone binary. I also tested withsynthetics upload-application
, which is another command using theform-data
package.How?
Bump
axios
andform-data
, and addnode_modules/axios/dist/node/axios.cjs
to thepkg.assets
to prevent the following error when running the standalone binary:Review checklist