Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Show error message on deployment correlate command #1445

Merged

Conversation

rodrigo-roca
Copy link
Contributor

@rodrigo-roca rodrigo-roca commented Sep 12, 2024

What and why?

We previously just showed the status code:

Failed to send deployment correlation data: Request failed with status code 400

But we want to show the error message so that the customers know what exactly is wrong

How?

A brief description of implementation details of this PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@rodrigo-roca rodrigo-roca added the ci-visibility Related to [junit, gate, metric, tag, trace, dora, deployment] label Sep 12, 2024
@rodrigo-roca rodrigo-roca self-assigned this Sep 12, 2024
@rodrigo-roca rodrigo-roca requested review from a team as code owners September 12, 2024 08:02
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 12, 2024

Datadog Report

Branch report: rodrigo.roca/improve-error-message-on-correlate-command
Commit report: 01018fb
Test service: datadog-ci-tests

✅ 0 Failed, 3808 Passed, 0 Skipped, 3m 2.57s Total duration (24.97s time saved)

Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had suggestions, but actually let me make a commit on your branch because this PR is a good opportunity to refactor some things a bit

src/commands/deployment/correlate.ts Outdated Show resolved Hide resolved
src/commands/deployment/correlate.ts Outdated Show resolved Hide resolved
@Drarig29 Drarig29 requested a review from a team as a code owner September 12, 2024 09:18
@Drarig29
Copy link
Contributor

@rodrigo-roca feel free to review my changes 😁

@rodrigo-roca
Copy link
Contributor Author

@Drarig29 Thanks for making the changes! They look good to me!

Copy link
Contributor

@Drarig29 Drarig29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Synthetics side

@rodrigo-roca rodrigo-roca merged commit cdd093d into master Sep 16, 2024
18 checks passed
@rodrigo-roca rodrigo-roca deleted the rodrigo.roca/improve-error-message-on-correlate-command branch September 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-visibility Related to [junit, gate, metric, tag, trace, dora, deployment]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants