-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Show error message on deployment correlate command #1445
[ci-visibility] Show error message on deployment correlate command #1445
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 3808 Passed, 0 Skipped, 3m 2.57s Total duration (24.97s time saved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had suggestions, but actually let me make a commit on your branch because this PR is a good opportunity to refactor some things a bit
@rodrigo-roca feel free to review my changes 😁 |
@Drarig29 Thanks for making the changes! They look good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on Synthetics side
What and why?
We previously just showed the status code:
But we want to show the error message so that the customers know what exactly is wrong
How?
A brief description of implementation details of this PR.
Review checklist