Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding junit intake url with env #439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilgelman
Copy link

Allow setting a custom junit intake url with DATADOG_JUNIT_INTAKE_URL environment variable

@@ -40,6 +40,7 @@ Additionally you might configure the `junit` command with environment variables:
- `DD_TAGS`: set global tags applied to all spans. The format must be `key1:value1,key2:value2`.
- The resulting dictionary will be merged with whatever is in the `--tags` parameter. If a `key` appears both in `--tags` and `DD_TAGS`, whatever value is in `DD_TAGS` will take precedence.
- `DATADOG_SITE`: choose your Datadog site, e.g. datadoghq.com or datadoghq.eu.
- `DATADOG_JUNIT_INTAKE_URL`: override the full URL for the intake endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something we want to show to users? Are we doing it for sourcemaps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems more like an internal thing

Copy link
Contributor

@jybp jybp Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI in the sourcemaps readme we do have it mentioned here:
It is also possible to override the full URL for the intake endpoint by defining the DATADOG_SOURCEMAP_INTAKE_URL environment variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sry I missed that. In any case, is there any reason to show it to users?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the only reason would be for the proxy case so customers can easily know what to configure.

Copy link
Contributor

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to block this PR until we figure out if HTTPS_PROXY can be used for this use case

@emilgelman
Copy link
Author

@juan-fernandez any news about this? This is blocking our team from using this feature.

@lraucy
Copy link
Contributor

lraucy commented Dec 1, 2021

@juan-fernandez any news about this? This is blocking our team from using this feature.

I just answered directly on the issue thread: #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants