Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate node 12 #72

Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat: Deprecate node 12 #72

merged 1 commit into from
Aug 16, 2022

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Aug 15, 2022

What does this PR do?

Closes #71

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner August 15, 2022 18:25
@astuyve
Copy link
Contributor Author

astuyve commented Aug 16, 2022

Verified this via creating a macro lambda stack from a this branch:
image

And instrumenting a SAM app (logs from the macro function running when deploying the SAM app):
image

and checking the layer/extension was correctly applied, the handler didn't error, and telemetry was passed to datadog.
image
image

@astuyve astuyve merged commit 933116d into master Aug 16, 2022
@astuyve astuyve deleted the aj/deprecate-node12 branch August 16, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End of support for Node.js v12.x
2 participants