Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for variables option #237

Merged
merged 21 commits into from
Jan 5, 2023
Merged

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Dec 21, 2022

This PR is based on and follow to: #232

Closes: #231

@skarimo skarimo added changelog/Added Added features results into a minor version bump do-not-merge/WIP Do not merge this PR labels Dec 21, 2022
@skarimo skarimo requested a review from a team as a code owner December 21, 2022 13:17
@github-actions github-actions bot added documentation Documentation related changes resource/monitor Impacts the datadog-monitors-monitor-handler package labels Dec 21, 2022
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments and a question.

therve
therve previously approved these changes Dec 22, 2022
@skarimo skarimo removed the do-not-merge/WIP Do not merge this PR label Dec 29, 2022
@skarimo skarimo merged commit a250bca into master Jan 5, 2023
@skarimo skarimo deleted the sherz/monitor-options-variables branch January 5, 2023 19:57
@niallyoung
Copy link
Contributor

🙇‍♂️ 👑 Thankyou Team 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump documentation Documentation related changes resource/monitor Impacts the datadog-monitors-monitor-handler package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datadog::Monitors::Monitor "#/Options: extraneous key [Variables] is not permitted"
4 participants