-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for variables
option
#237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles, TODO spin up a class
This reverts commit 28826ba.
skarimo
added
changelog/Added
Added features results into a minor version bump
do-not-merge/WIP
Do not merge this PR
labels
Dec 21, 2022
github-actions
bot
added
documentation
Documentation related changes
resource/monitor
Impacts the datadog-monitors-monitor-handler package
labels
Dec 21, 2022
6 tasks
therve
reviewed
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments and a question.
datadog-monitors-monitor-handler/datadog-monitors-monitor-configuration.json
Outdated
Show resolved
Hide resolved
datadog-monitors-monitor-handler/src/datadog_monitors_monitor/handlers.py
Outdated
Show resolved
Hide resolved
datadog-monitors-monitor-handler/src/datadog_monitors_monitor/handlers.py
Outdated
Show resolved
Hide resolved
datadog-monitors-monitor-handler/src/datadog_monitors_monitor/handlers.py
Outdated
Show resolved
Hide resolved
datadog-monitors-monitor-handler/src/datadog_monitors_monitor/handlers.py
Outdated
Show resolved
Hide resolved
therve
previously approved these changes
Dec 22, 2022
nkzou
approved these changes
Jan 5, 2023
🙇♂️ 👑 Thankyou Team 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/Added
Added features results into a minor version bump
documentation
Documentation related changes
resource/monitor
Impacts the datadog-monitors-monitor-handler package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on and follow to: #232
Closes: #231