feat: Add option for Processor to drop metrics #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the AddMetric function to be truly non-blocking even if we risk loosing some metrics. Signed-off-by: Tobias Germer <tobias.germer@tui.com>
mycrEEpy
force-pushed
the
custom-metrics-no-blocking
branch
from
791ff4d to
522f1e4
Compare
|
Closing stale PRs |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add two parameters
MetricsChannelCapacityandDropMetricsAtCapacity.This will allow the
AddMetricfunction to be truly non-blocking even if we risk loosing some metrics.The default will remain at a channel capacity of 2000 and blocking to wait for capacity.
Motivation
Following the DataDog outage of 2023.03.08 in EU central some of our Lambdas were blocking due to the blocking nature of the
AddMetricfunction in cases where themetricsChanis at capacity.Testing Guidelines
Added test case
TestProcessorBatchesDropMetricsAtCapacityAdditional Notes
Types of changes
Checklist