Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/trace/listener: Don't override service name #155

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

piochelepiotr
Copy link
Collaborator

@piochelepiotr piochelepiotr commented Jan 24, 2024

What does this PR do?

Today, if DD_SERVICE is used, the service name is still set to aws.lambda.
This PR removes that logic, and uses the defaults of the Go tracer (so defaulting to the binary name).

Motivation

Testing Guidelines

Behavior before:

Traces have a service name aws.lambda is DD_SERVICE isn't set
Data streams have a service aws.lambda if DD_SERVICE isn't set

If DD_SERVICE is set, only APM picks it up.

Behavior after:

Same if DD_SERVICE isn't set

If DD_SERVICE is set, both APM service name & DSM service name use it.
image

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@piochelepiotr piochelepiotr requested a review from a team as a code owner January 24, 2024 21:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0daaf53) 82.29% compared to head (28b2d41) 82.39%.

❗ Current head 28b2d41 differs from pull request most recent head 1643835. Consider uploading reports for the commit 1643835 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   82.29%   82.39%   +0.09%     
==========================================
  Files          13       13              
  Lines         887      886       -1     
==========================================
  Hits          730      730              
+ Misses        127      126       -1     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piochelepiotr piochelepiotr merged commit 6331b15 into main Feb 1, 2024
9 checks passed
@piochelepiotr piochelepiotr deleted the piotr-wolski/dont-override-service-name branch February 1, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants