internal/trace/listener: Don't override service name #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Today, if
DD_SERVICE
is used, the service name is still set toaws.lambda
.This PR removes that logic, and uses the defaults of the Go tracer (so defaulting to the binary name).
Motivation
Testing Guidelines
Behavior before:
Traces have a service name
aws.lambda
isDD_SERVICE
isn't setData streams have a service
aws.lambda
ifDD_SERVICE
isn't setIf DD_SERVICE is set, only APM picks it up.
Behavior after:
Same if DD_SERVICE isn't set
If DD_SERVICE is set, both APM service name & DSM service name use it.
Additional Notes
Types of changes
Checklist