Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes sampling rates not being respected.
When a sampling priority is set on a span but not in the context, we should still propagate it to the Lambda extension. Previously the sampling priority was not being sent to the extension in this case, causing sampling rates to be incorrect.
Motivation
Sampling rates didn't work before, leading to 100% of traces being sampled regardless of the
DD_TRACE_SAMPLING_RULES
orDD_TRACE_SAMPLE_RATE
environment variables.Testing Guidelines
Manual testing. Before changes, we saw every trace was being sampled. Now, we see the correct number of traces being sampled depending on the sample rate environment variable.
I also added unit tests in
extension_test.go
.Additional Notes
Types of changes
Checklist