Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Upgrade to dd-trace-js version 3.x #375

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Apr 3, 2023

What does this PR do?

Breaking change which upgrades this library to dd-trace-js v3.x

Motivation

Bug fixes, performance improvements, etc. All detailed here in the migration guide

Testing Guidelines

We've been running this in our self-monitoring application for ~4 days successfully.

I've also deployed a test service which verifies tracing managed services, cold start tracing, and trace propagation is all working:
image

Additional Notes

When we release this, we'll need to update our documentation regarding node12 support.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner April 3, 2023 19:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #375 (92b9b31) into main (def89b9) will not change coverage.
The diff coverage is n/a.

❗ Current head 92b9b31 differs from pull request most recent head 6f09dc6. Consider uploading reports for the commit 6f09dc6 to get more accurate results

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   80.89%   80.89%           
=======================================
  Files          38       38           
  Lines        1931     1931           
  Branches      448      448           
=======================================
  Hits         1562     1562           
  Misses        313      313           
  Partials       56       56           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astuyve astuyve merged commit 14da053 into main Apr 11, 2023
@astuyve astuyve deleted the aj/BREAKING-dd-trace-3 branch April 11, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants