Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add response streaming #376

Merged
merged 10 commits into from
Apr 7, 2023

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Adds support for response streaming functions.

Motivation

AWS just launched response streaming support for AWS Lambda functions.

Testing Guidelines

  • Added unit tests
  • Tested manually on self-monitoring app.
  • Tested a streamed image which payload was bigger than 6MB.

Additional Notes

This could be considered a bug, since our current work wouldn't work out of the box. Now it's working as expected.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

make sure we update status to check if a function is response streaming
make sure response streaming functions are instrumented correctly
@duncanista duncanista requested a review from a team as a code owner April 7, 2023 21:37
astuyve and others added 3 commits April 7, 2023 17:39
…thub.com/DataDog/datadog-lambda-js into jordan.gonzalez/support-response-streaming
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #376 (9d0527a) into main (56f6227) will increase coverage by 0.35%.
The diff coverage is 85.00%.

❗ Current head 9d0527a differs from pull request most recent head 8640398. Consider uploading reports for the commit 8640398 to get more accurate results

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   80.53%   80.89%   +0.35%     
==========================================
  Files          38       38              
  Lines        1901     1931      +30     
  Branches      439      448       +9     
==========================================
+ Hits         1531     1562      +31     
  Misses        313      313              
+ Partials       57       56       -1     
Impacted Files Coverage Δ
src/trace/listener.ts 65.00% <33.33%> (+0.83%) ⬆️
src/index.ts 88.15% <85.18%> (+0.56%) ⬆️
src/constants.ts 100.00% <100.00%> (ø)
src/trace/trigger.ts 89.22% <100.00%> (+1.19%) ⬆️
src/utils/handler.ts 91.22% <100.00%> (+0.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@duncanista duncanista merged commit c9c0fdc into main Apr 7, 2023
@duncanista duncanista deleted the jordan.gonzalez/support-response-streaming branch April 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants