-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add response streaming #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure we update status to check if a function is response streaming
make sure response streaming functions are instrumented correctly
astuyve
approved these changes
Apr 7, 2023
…thub.com/DataDog/datadog-lambda-js into jordan.gonzalez/support-response-streaming
Codecov Report
@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 80.53% 80.89% +0.35%
==========================================
Files 38 38
Lines 1901 1931 +30
Branches 439 448 +9
==========================================
+ Hits 1531 1562 +31
Misses 313 313
+ Partials 57 56 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for response streaming functions.
Motivation
AWS just launched response streaming support for AWS Lambda functions.
Testing Guidelines
Additional Notes
This could be considered a bug, since our current work wouldn't work out of the box. Now it's working as expected.
Types of Changes
Check all that apply