-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aj/fix lazy imports #393
aj/fix lazy imports #393
Conversation
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 80.88% 80.74% -0.14%
==========================================
Files 38 38
Lines 1930 1937 +7
Branches 448 449 +1
==========================================
+ Hits 1561 1564 +3
- Misses 313 316 +3
- Partials 56 57 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a52cf4b
to
95f2c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just one question, now this cold start tracer turns into a double purpose because traces requires during execution? Or am I missing it?
@duncanista good question - it was always meant to trace module load times, we branded it |
What does this PR do?
Needs tests.
This fixes an issue where lazy imports weren't traced.
This now parents them to the lambda span, like so:
Normal cold start traces are unaffected:
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply