Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump dd-trace to 3.24 which includes fix for unhandled promise exceptions from lambda handlers #399

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Jun 23, 2023

What does this PR do?

fixes DataDog/dd-trace-js#2893

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner June 23, 2023 17:07
Copy link
Contributor

@zARODz11z zARODz11z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this change won't affect users as its a dev dependency upgrade but when we build the layers there is some config that pulls the latest dd trace version

Copy link
Contributor

@kimi-p kimi-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@astuyve
Copy link
Contributor Author

astuyve commented Jun 23, 2023

@zARODz11z not quite, we install this as a dev dependency so that users can bring their own version of dd-trace if they install this library separately.

However, when we build the layers, we explicitly copy this dependency into the final docker build using this script

@astuyve astuyve merged commit 509e900 into main Jun 23, 2023
@astuyve astuyve deleted the aj/dd-trace-unhandled-promise-fix branch June 23, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda errors are always wrapped as Runtime.UnhandledPromiseRejection
3 participants