Fix Upstream Service Mapping #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bda-js into ar/fixServiceMapping
zARODz11z
commented
Aug 24, 2023
| @@ -112,12 +112,12 @@ export class SpanInferrer { | |||
| endpoint: path, | |||
| resource_names: resourceName, | |||
| request_id: context?.awsRequestId, | |||
There was a problem hiding this comment.
Via this branch I published v20 of dd lambda js to sandbox and asserted correct upstream service mapping for apigw and sns. The other services service.name are properly being added as shown by the spec file above and snapshots
There was a problem hiding this comment.
the issue why remapping wasnt working was the service.name is supported by backend and in the past it when it wasn't present it must of fallen back to the lambda function service name
There was a problem hiding this comment.
zARODz11z
changed the title
astuyve
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes inferred spans service mapping by using service.name
Motivation
See SLS-4019 for more context, upstream service mapping not working in JS due to not using service.name
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply