chore: lazy load internal request module #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 81.95% 81.90% -0.06%
==========================================
Files 54 54
Lines 2206 2205 -1
Branches 512 513 +1
==========================================
- Hits 1808 1806 -2
+ Misses 334 333 -1
- Partials 64 66 +2 ☔ View full report in Codecov by Sentry. |
…github.com/DataDog/datadog-lambda-js into jordan.gonzalez/lazy-load-fallback-processor
11 tasks
duncanista
commented
Mar 20, 2024
| @@ -56,7 +54,7 @@ export interface MetricsConfig { | |||
| } | |||
|
|
|||
| export class MetricsListener { | |||
| private currentProcessor?: Promise<Processor>; | |||
| private currentProcessor?: Promise<any>; | |||
There was a problem hiding this comment.
Sadly, this has to stay as it, so we don't import and load the modules that add 1MB of memory allocation.
duncanista
commented
Mar 20, 2024
| @@ -33,6 +33,8 @@ export function unpatchHttp() { | |||
| } | |||
|
|
|||
| function patchMethod(mod: typeof http | typeof https, method: "get" | "request", contextService: TraceContextService) { | |||
| if (mod[method].__wrapped !== undefined) return; // Only patch once | |||
There was a problem hiding this comment.
This was missed, required so no repeated logs appear.
purple4reina
approved these changes
Mar 20, 2024
| const processor = new Processor(apiClient, metricsBatchSendIntervalMS, config.shouldRetryMetrics); | ||
| processor.startProcessing(); | ||
| return processor; | ||
| if (!this.isExtensionRunning && !this.config.logForwarding) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduces memory allocation for this package by lazy loading internal
request.tsmethods.Before:
After:
Motivation
It was possible to reduce the memory allocations + performance.
Testing Guidelines
Additional Notes
SVLS-4628
Allocation time can vary, but now we are sure that the lazy load is in effect.
Types of Changes
Check all that apply