Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a step to extract the dependencies info when building the layers #375

Closed
wants to merge 1 commit into from
Closed

add a step to extract the dependencies info when building the layers #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/build_layers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ function docker_build_zip {
(cd $temp_dir && zip -q -r $destination ./)

rm -rf $temp_dir
docker run datadog-lambda-python-${arch}:$1 sh -c "cd /build/python/lib/python$1/site-packages/ && \
python -c \"import pkg_resources; packages = sorted(['%s==%s' % (i.key, i.version) for i in pkg_resources.working_set]);\
print(*packages,sep ='\n')\"" > dependency.lock.${arch}.$1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note in the release step to read this file and include the ddtrace version in the release notes? I'm thinking something around

datadog-lambda-python/scripts/publish_prod.sh

Line 95 in 962813a

echo "Now create a new release with the tag v${LAYER_VERSION} created"
.

echo "Done creating archive $destination"
}

Expand Down