Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If the datadog serverless plugin is used, which automatically wraps the function's handler with
@datadog_lambda_wrapper
, and the handler function is also decorated with@datadog_lambda_wrapper
, the resulted code is equivalent to the following, and two wrappers get created.This results in
__init__
get called twice on cold start and__call__
gets called twice on every invocation. Because not every operation in those two methods are idempotent, this causes unexpected behaviors. E.g.,aws.lambda.enhanced.invocations
will get submitted twice for every single invocation.Let
@datadog_lambda_wrapper
instantiate a no-op decorator_NoopDecorator
when a wrapper is already instantiated. But allow_force_new
to force create a new/real wrapper every time, which is needed by the unit tests.