Skip to content

chore: support python 3.13 #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apiarian-datadog
Copy link
Contributor

@apiarian-datadog apiarian-datadog commented Nov 22, 2024

What does this PR do?

Adding Python 3.13 support.

Testing Guidelines

Unit tests, integration tests, and self-monitoring checks.

Motivation

SVLS-6020

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@apiarian-datadog
Copy link
Contributor Author

This isn't ready since Python 3.13 isn't supported by the dd-trace-py yet.

@@ -61,7 +61,7 @@ function docker_build_zip {
# between different python runtimes.
temp_dir=$(mktemp -d)
docker buildx build -t datadog-lambda-python-${arch}:$1 . --no-cache \
--build-arg image=python:$1 \
--build-arg image=public.ecr.aws/docker/library/python:$1 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we kept hitting rate limit errors from dockerhub, so we're switching to the public aws ecr instead.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5989-support-python3.13 branch from 3af3a80 to 8d1de37 Compare January 6, 2025 18:18
@apiarian-datadog
Copy link
Contributor Author

the diff between the integration test snapshots for python 3.12 and 3.13 don't show any interesting differences, just notes that one of them is using python 3.12 and the other is using python 3.13.

@dbast
Copy link

dbast commented Jan 22, 2025

dd-trace-py with Python 3.13 support got released some days ago, see https://github.com/DataDog/dd-trace-py/releases/tag/v2.19.0

@apiarian-datadog
Copy link
Contributor Author

dd-trace-py with Python 3.13 support got released some days ago, see DataDog/dd-trace-py@v2.19.0 (release)

@dbast thanks for the reminder! i'll re-test our layer but since python 3.13 support in 2.19.0 is still somewhat experimental, we're planning to wait for the 2.20.0 release for actually releasing this change.

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5989-support-python3.13 branch from 8d1de37 to 3766511 Compare January 22, 2025 16:21
@christopherschroer
Copy link

christopherschroer commented Jan 27, 2025

dd-trace-py v2.20.0 was released

@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5989-support-python3.13 branch from 3766511 to cc4d20d Compare January 28, 2025 15:54
@apiarian-datadog apiarian-datadog marked this pull request as ready for review January 28, 2025 20:29
@apiarian-datadog apiarian-datadog requested a review from a team as a code owner January 28, 2025 20:29
@apiarian-datadog
Copy link
Contributor Author

no significant differences between the new python 3.13 integration test output files and their analogous python 3.12 versions

Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, please make sure you create the equivalent changes necessary in self-monitoring so this runs on 3.13 on the core stacks: extension, fullinstrument, baseline, etc.

@duncanista duncanista changed the title chore: [SVLS-5989] add python 3.13 to our configs chore: support python 3.13 Jan 28, 2025
@apiarian-datadog apiarian-datadog force-pushed the aleksandr.pasechnik/svls-5989-support-python3.13 branch from c52baed to 9b2bb87 Compare January 29, 2025 21:48
@apiarian-datadog apiarian-datadog merged commit 6117772 into main Jan 30, 2025
59 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/svls-5989-support-python3.13 branch January 30, 2025 13:56
mabdinur pushed a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants