Skip to content

chore: Use GitHub App for update-deps workflow #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Jun 3, 2025

What does this PR do?

Makes the upgrade workflow use GitHub Apps to get temporary tokens instead of using a long-lived SSH key.

Motivation

This workflow is broken, probably because the SSH key no longer works. Instead of creating a new SSH key, we use a GitHub App, which generates short-lived tokens and is more secure than SSH key.

Testing Guidelines

Will test the workflow after this PR is merged to main because I can't manually trigger it right now.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

Jira: https://datadoghq.atlassian.net/browse/SVLS-6930

@lym953 lym953 requested review from a team as code owners June 3, 2025 21:02
@lym953 lym953 merged commit 254466c into main Jun 4, 2025
60 checks passed
@lym953 lym953 deleted the yiming.luo/gh-app branch June 4, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants