APMSVLS-212 Reducing Python Lambda Layer Size #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # benchmark uses pre-built wheels instead of building from sources. | ||
| RUN find ./python/lib/$runtime/site-packages/ddtrace -name "*.so" -exec strip -g {} \; | ||
| RUN find ./python/lib/$runtime/site-packages -name "*.so" -exec strip -g {} \; | ||
| # RUN find ./python/lib/$runtime/site-packages/ddtrace -name "*.so" -exec strip -g {} \; |
There was a problem hiding this comment.
hGreat idea! I'm surprised we weren't already stripping all the binaries in site-packages. Good find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies
strip --strip-unneededto all.sofiles included in the Python lambda layer.Motivation
Frequent increases in Python lambda layer size, exceeding checks.
Stripping binaries further (originally only applied
strip --strip-debug) can reduce the unzipped layer size by about 2.5MB.Testing Guidelines
Ran serverless e2e tests and manually inspected traces on a Python sample app.
Additional Notes
Types of Changes
Check all that apply