Statsd integration #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhinsch
reviewed
Oct 8, 2020
datadog_lambda/metric.py
Outdated
|
|
||
| class StatsDWrapper: | ||
| """ | ||
| Wraps StatsD calls, to give an identical to ThreadStats |
nhinsch
reviewed
Oct 8, 2020
tests/test_wrapper.py
Outdated
| self.addCleanup(patcher.stop) | ||
| # patcher = patch("datadog_lambda.metric.lambda_metric") | ||
| # self.mock_lambda_metric = patcher.start() | ||
| # self.addCleanup(patcher.stop) |
There was a problem hiding this comment.
We were patching the datadog_lambda.metric.lambda_metric out for testing, but the new code uses it internally, so I unpatched it. I'll remove this snippet.
Czechh
approved these changes
Oct 8, 2020
nhinsch
reviewed
Oct 8, 2020
datadog_lambda/extension.py
Outdated
| return True | ||
|
|
||
|
|
||
| use_extension = is_extension_running() |
There was a problem hiding this comment.
To me, use_extension sounds like a verb, i.e. if I call it, then the extension will be used. But it seems like it represents whether the extension should be used. Maybe rename this to is_using_extension or should_use_extension or something along those lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports the extension via statsd