Add details regarding watched namespaces for the DatadogMonitor objects #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Does This PR Do? - Adds additional context for use specifying the `namespaces` Motivation: https://datadog.zendesk.com/agent/tickets/1666229
Dog-Gone-Earl
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
+ Coverage 59.54% 59.64% +0.09%
==========================================
Files 174 175 +1
Lines 21510 22310 +800
==========================================
+ Hits 12809 13306 +497
- Misses 7930 8199 +269
- Partials 771 805 +34
Flags with carried forward coverage won't be shown. Click here to find out more. see 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brett0000FF
approved these changes
Apr 30, 2024
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Updated of code block configuration for syntax corrections.
Dog-Gone-Earl
changed the title
Update of syntax of code block section for proper markup of numbered list
celenechang
reviewed
May 2, 2024
celenechang
reviewed
May 2, 2024
Removed highlighting the word namespace for conformity. Co-authored-by: Celene <celene@datadoghq.com>
Adding *Note* on increased memory usage with adding namesapces referenced: #967
Updates of format for conformity. Co-authored-by: Celene <celene@datadoghq.com>
Re-formatted to reduce repetition of `Note` identifiers.
celenechang
reviewed
May 16, 2024
celenechang
reviewed
May 16, 2024
docs/datadog_monitor.md
Outdated
| @@ -130,3 +142,4 @@ kubectl logs <my-datadog-operator-pod-name> | |||
| [5]: https://app.datadoghq.com/account/settings#api | |||
| [6]: https://github.com/DataDog/helm-charts/blob/master/charts/datadog-operator/values.yaml | |||
| [7]: https://app.datadoghq.com/monitors/manage?q=tag%3A"generated%3Akubernetes" | |||
| [8]: https://github.com/DataDog/helm-charts/blob/main/charts/datadog-operator/values.yaml#L147-L156 | |||
There was a problem hiding this comment.
Since line numbers will change on main, and we want the doc to be timeless, perhaps we can remove this reference and just re-use [6]
There was a problem hiding this comment.
Hi @celenechang , thank you for this! I agree as it is a fluid document, it should not be referenced. And a little redundant from [6] already referencing main page.
There was a problem hiding this comment.
Hi @celenechang. Apologies for the delay. Just wanted to see if this PR was good to go or already released by another PR?
There was a problem hiding this comment.
Hi! I'm sorry too. This looks good to me. Just an FYI, there are more refined configuration options coming with the next Operator version, but we can update the doc again after it's released
Co-authored-by: Celene <celene@datadoghq.com>
Removal of [8] reference link.
celenechang
approved these changes
Jul 30, 2024
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ts (#1158) * Update datadog_monitor.md What Does This PR Do? - Adds additional context for use specifying the `namespaces` Motivation: https://datadog.zendesk.com/agent/tickets/1666229 * Update docs/datadog_monitor.md Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> * Update docs/datadog_monitor.md Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> * Update datadog_monitor.md Updated of code block configuration for syntax corrections. * Update datadog_monitor.md Update of syntax of code block section for proper markup of numbered list * Update docs/datadog_monitor.md Removed highlighting the word namespace for conformity. Co-authored-by: Celene <celene@datadoghq.com> * Update datadog_monitor.md Adding *Note* on increased memory usage with adding namesapces referenced: #967 * Update docs/datadog_monitor.md Updates of format for conformity. Co-authored-by: Celene <celene@datadoghq.com> * Update datadog_monitor.md Re-formatted to reduce repetition of `Note` identifiers. * Update docs/datadog_monitor.md Co-authored-by: Celene <celene@datadoghq.com> * Update datadog_monitor.md Removal of [8] reference link. --------- Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> Co-authored-by: Celene <celene@datadoghq.com>
mftoure
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ts (#1158) * Update datadog_monitor.md What Does This PR Do? - Adds additional context for use specifying the `namespaces` Motivation: https://datadog.zendesk.com/agent/tickets/1666229 * Update docs/datadog_monitor.md Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> * Update docs/datadog_monitor.md Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> * Update datadog_monitor.md Updated of code block configuration for syntax corrections. * Update datadog_monitor.md Update of syntax of code block section for proper markup of numbered list * Update docs/datadog_monitor.md Removed highlighting the word namespace for conformity. Co-authored-by: Celene <celene@datadoghq.com> * Update datadog_monitor.md Adding *Note* on increased memory usage with adding namesapces referenced: #967 * Update docs/datadog_monitor.md Updates of format for conformity. Co-authored-by: Celene <celene@datadoghq.com> * Update datadog_monitor.md Re-formatted to reduce repetition of `Note` identifiers. * Update docs/datadog_monitor.md Co-authored-by: Celene <celene@datadoghq.com> * Update datadog_monitor.md Removal of [8] reference link. --------- Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com> Co-authored-by: Celene <celene@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
namespacesMotivation
Additional Notes
N/A
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
minikubesandbox.DatadogMonitornot found when Operator was in differentnamespaceor vice-a-versa.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel