-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix behavior when overriding names of DCA and CCR components #1448
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
+ Coverage 49.01% 49.15% +0.14%
==========================================
Files 223 223
Lines 19508 19562 +54
==========================================
+ Hits 9562 9616 +54
+ Misses 9456 9444 -12
- Partials 490 502 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
internal/controller/datadogagent/controller_reconcile_ccr_test.go
Outdated
Show resolved
Hide resolved
a5438e0
to
7c532a9
Compare
What does this PR do?
Fix behavior when overriding names of DCA and CCR components. Previously, the old DCA and CCR components do not get cleaned up when changing the override names. Only the node agent component gets cleaned up.
Motivation
CECO-1136
Describe your test plan
Use the following
DatadogAgent
configurations to change the default name of the components:After the pods are successfully running, change the config to this:
Run
kubectl get pods
and you should see that the old pod names for the DCA and CCR are cleaned up and terminated and the new ones should be running with the following names for the node agent, DCA, and CCR respectively:Can also remove the above configurations and check if the clean up is happening as expected and the new ones should default to the original names. For example, if you named your DatadogAgent as
datadog
, it should just be:Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label