Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service discovery: Add operator support #1449

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

guyarb
Copy link

@guyarb guyarb commented Oct 6, 2024

What does this PR do?

Adds service-discovery check to the operator.

Motivation

Allow to control service-discovery from the operator.

Additional Notes

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.58.0
  • Cluster Agent: N/A

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@guyarb guyarb requested review from a team as code owners October 6, 2024 13:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@guyarb guyarb added the enhancement New feature or request label Oct 6, 2024
@guyarb guyarb added this to the v1.10.0 milestone Oct 6, 2024
@guyarb guyarb force-pushed the guy.arbitman/USMON-1227-service-discovery-to-agent-operator branch from d583968 to cc34cfd Compare October 6, 2024 14:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.11%. Comparing base (7fe7979) to head (6b2b5dc).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...r/datadogagent/feature/servicediscovery/feature.go 83.33% 9 Missing and 1 partial ⚠️
internal/controller/testutils/agent.go 0.00% 10 Missing ⚠️
internal/controller/datadogslo/controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
+ Coverage   49.01%   49.11%   +0.09%     
==========================================
  Files         223      224       +1     
  Lines       19501    19576      +75     
==========================================
+ Hits         9559     9614      +55     
- Misses       9453     9472      +19     
- Partials      489      490       +1     
Flag Coverage Δ
unittests 49.11% <71.42%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/datadogagent_default.go 89.88% <100.00%> (+0.14%) ⬆️
api/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)
internal/controller/datadogagent/controller.go 55.17% <ø> (ø)
internal/controller/datadogslo/controller.go 56.52% <0.00%> (ø)
...r/datadogagent/feature/servicediscovery/feature.go 83.33% <83.33%> (ø)
internal/controller/testutils/agent.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe7979...6b2b5dc. Read the comment docs.

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a tiny edit

docs/configuration.v2alpha1.md Outdated Show resolved Hide resolved
@levan-m levan-m modified the milestones: v1.10.0, v1.11.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants