-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admission controller): Add new webhook settings #1461
base: main
Are you sure you want to change the base?
Conversation
7f67f67
to
9033d58
Compare
b40425c
to
48bfe1f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 48.70% 48.80% +0.10%
==========================================
Files 224 224
Lines 19852 19886 +34
==========================================
+ Hits 9669 9706 +37
+ Misses 9675 9673 -2
+ Partials 508 507 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
9cb8b16
to
0c2c5d4
Compare
Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
0c2c5d4
to
b97385e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious. What are some potential future mutating and validation configurations (besides just enabled true/false) that could be used by the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future I would like to relocate the mutate_unlabelled
setting to the mutation
section (while keeping backward compatibility) and also add a validate_unlabelled
one for the validation
.
@@ -254,7 +273,7 @@ func testDCAResources(acm string, registry string, cwsInstrumentationEnabled boo | |||
) | |||
} | |||
|
|||
func getACEnvVars(acm, registry string, cws bool) []*corev1.EnvVar { | |||
func getACEnvVars(validation, mutation bool, acm, registry string, cws bool) []*corev1.EnvVar { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why not add the validation and mutation bool at the end with the cws bool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered them to be more "important" as the other ones since they control the main Validation and Mutation functionality.
What does this PR do?
Add support for the new Cluster Agent Admission settings.
Motivation
Needed to support new Cluster Agent settings.
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Using the following settings:
Make sure that the output of those commands is as follows:
Modify the setting with:
Make sure that the output changes to:
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label