-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DatadogAgent][Flare] Additional environment variables and RBAC to permit user manifests retrieval #1477
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
==========================================
+ Coverage 48.70% 48.75% +0.04%
==========================================
Files 224 225 +1
Lines 19845 19879 +34
==========================================
+ Hits 9666 9692 +26
- Misses 9670 9678 +8
Partials 509 509
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
DDAgentDaemonSet = "AGENT_DAEMONSET" | ||
DDClusterAgentDeployment = "CLUSTER_AGENT_DEPLOYMENT" | ||
DDDatadogAgentCustomResource = "DATADOG_AGENT_CR_NAME" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DDAgentDaemonSet = "AGENT_DAEMONSET" | |
DDClusterAgentDeployment = "CLUSTER_AGENT_DEPLOYMENT" | |
DDDatadogAgentCustomResource = "DATADOG_AGENT_CR_NAME" | |
DDAgentDaemonSet = "NODE_AGENT_DAEMONSET" | |
DDClusterAgentDeployment = "CLUSTER_AGENT_DEPLOYMENT" | |
DDDatadogAgentCustomResource = "DATADOGAGENT_CR_NAME" |
What does this PR do?
AGENT_DAEMONSET
: name of the node Agent dsCLUSTER_AGENT_DEPLOYMENT
: name of the DCA deploymentDATADOG_AGENT_CR_NAME
: name of theDatadogAgent
custom resourceget
theDatadogAgent
custom resource from its namespaceMotivation
Similar to DataDog/helm-charts#965, we need to inject a few variables/give some permissions to be able to collect the Agent deployment files while creating a flare to help with troubleshooting.
Additional Notes
The flare feature depending on these variables is available at: DataDog/datadog-agent#30372
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
DatadogAgent
with cluster Agent enabled (default):AGENT_DAEMONSET
:foo-agent
, value ofkubectl get ds
CLUSTER_AGENT_DEPLOYMENT
:foo-cluster-agent
, value ofkubectl get deploy
DATADOG_AGENT_CR_NAME
:foo
, value ofkubectl get dd
AGENT_DAEMONSET
:x
, value ofkubectl get ds
CLUSTER_AGENT_DEPLOYMENT
:y
, value ofkubectl get deploy
DATADOG_AGENT_CR_NAME
:foo
, value ofkubectl get dd
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label