Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable otel-agent using DDA annotation (#1475) #1480

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Oct 22, 2024

What does this PR do?

Cherry-pick #1475

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m added the enhancement New feature or request label Oct 22, 2024
@levan-m levan-m added this to the v1.10.0 milestone Oct 22, 2024
@levan-m levan-m requested a review from a team as a code owner October 22, 2024 18:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.90%. Comparing base (37dbabd) to head (fd3db70).

Files with missing lines Patch % Lines
...ller/datadogagent/feature/enabledefault/feature.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            v1.10    #1480   +/-   ##
=======================================
  Coverage   48.89%   48.90%           
=======================================
  Files         225      225           
  Lines       19821    19828    +7     
=======================================
+ Hits         9692     9696    +4     
- Misses       9626     9628    +2     
- Partials      503      504    +1     
Flag Coverage Δ
unittests 48.90% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/test/builder.go 92.00% <100.00%> (+0.05%) ⬆️
...ller/datadogagent/feature/enabledefault/feature.go 34.57% <0.00%> (-0.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37dbabd...fd3db70. Read the comment docs.

@levan-m levan-m merged commit 60e9a47 into v1.10 Oct 22, 2024
16 checks passed
@levan-m levan-m deleted the levan-m/cherry-pick-1475 branch October 22, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants