Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint timeout to 10m #1494

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

  • Bump golangci-lint timeout to 10m
  • Also updates go.work.sum

Motivation

Frequent unit-tests job timeouts due to the linter

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@fanny-jiang fanny-jiang added this to the v1.10.0 milestone Oct 28, 2024
@fanny-jiang fanny-jiang requested a review from a team as a code owner October 28, 2024 20:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.70%. Comparing base (7b66b25) to head (d341ece).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   48.70%   48.70%           
=======================================
  Files         224      224           
  Lines       19845    19845           
=======================================
  Hits         9666     9666           
  Misses       9670     9670           
  Partials      509      509           
Flag Coverage Δ
unittests 48.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b66b25...d341ece. Read the comment docs.

@fanny-jiang fanny-jiang merged commit a33ab18 into main Oct 29, 2024
22 checks passed
@fanny-jiang fanny-jiang deleted the fanny/golangci-lint-timeout branch October 29, 2024 16:38
fanny-jiang added a commit that referenced this pull request Oct 29, 2024
fanny-jiang added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants