JSON Schema for the static analyzer configuration file. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobotb
force-pushed
the
jacobotb/STAL-1373/config_schema
branch
from
ae92722
to
52e12d7
Compare
juli1
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Looks great! Two asks
- Can we put the content of the
README.mdinto the mainREADME.md? - Can we have at least a description of the PR and explain the motivation?
- Can we also integrate the tests (e.g. at least testing the schema) in the CI workflow to ensure that a change of the schema will be tested to avoid/prevent regression? No need to do anything fancy here, something similar to this
jacobotb
requested review from
modernplumbing
and removed request for
modernplumbing
|
Added integration schema test, moved documentation to main README.md, updated PR description. |
juli1
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The IDE plugins need to be able to parse the static analyzer configuration file. Therefore, there needs to be a definition they can use to build their parser.
What is your solution?
A schema definition, with its tests, that defines the format.
Alternatives considered
What the reviewer should know