Replace glob_match with globset #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glob_match crate has a bug with a pattern like **/*test*.py , where a file like abc/test/def/test.py does not match. Or even t/test.py does not match.
juli1
reviewed
Mar 6, 2024
juli1
reviewed
Mar 6, 2024
juli1
reviewed
Mar 6, 2024
Comment on lines
+156
to
+162
| fn matches_pattern(pattern: &PathPattern, path: &str) -> bool { | ||
| pattern | ||
| .glob | ||
| .as_ref() | ||
| .map(|g| g.is_match(path)) | ||
| .unwrap_or(false) | ||
| || Path::new(path).starts_with(&pattern.prefix) |
There was a problem hiding this comment.
Can we implement this as part of the PathPattern struct?
impl PathPattern {
fn match(path: &str) {
....
}
}
This way, we made sure we tie/attach this function to each type? This occurred to me after reading the clarification about the `PathPattern`, it seems this function would be part of the "type".
juli1
approved these changes
Mar 6, 2024
|
Approved and agreed on a follow up to make the function as part of a type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The
glob_matchcrate has a bug with a pattern like**/*test*.py, where a file likeabc/test/def/test.pydoes not match.Or even
t/test.pydoes not match.See devongovett/glob-match#9 for issue.
What is your solution?
The
globsetcrate does not have that bug and is pretty fast too.Alternatives considered
What the reviewer should know
globsethas a separate compilation step, so I do it during configuration parsing.