[STAL-2925] feat: ignore auto-generated C# files #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
force-pushed
the
amaan.qureshi/STAL-2925
branch
from
00071bb
to
80b97f5
Compare
juli1
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Currently, we do not handle auto-generated C# files. Someone reached out to us about violations appearing on autogenerated C# files when they shouldn't be.
What is your solution?
We should ignore autogenerated C# files like we do for several other languages. The heuristics used come from the C# Roslyn analyzer and compiler itself, and a summary of what these heuristics are can be found on this slack thread from 2020, which points to this file in Roslyn for handling autogenerated file detection.
The heuristics are:
<autogeneratedor<auto-generatedTemporaryGeneratedFile_(case insensitive).designer,.generated,.g, or.g.i(case insensitive, e.g.foo.designer.cs)Alternatives considered
What the reviewer should know
The failing CI for the regression checks w.r.t. C# repos is expected, there are some files we no longer process now as a result of the changes in this PR.