Pin workflow to @actions/core@1.10.1 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Our regression check JavaScript script specifies
@actions/core@^1.10.6as a dependency. Two days ago, v1.11.0 was released, and this breaks our workflow with the following error:(I artificially introduced this regression -- job here)
The upstream issue of note is actions/toolkit#1841. It seems upgrading to Node 20 would also solve this for us, but pinning seems more prudent at the moment.
What is your solution?
Pin to exactly
1.10.6.Re-running the job shows it now works:
Alternatives considered
What the reviewer should know