Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STAL-3119] Fix folder structure for Windows release zip #547

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

jasonforal
Copy link
Collaborator

@jasonforal jasonforal commented Nov 4, 2024

What problem are you trying to solve?

With #534, we changed the action steps that performed the release, and in doing so, inadvertently changed the folder structure of the zip for Windows.

For example, it's now:

.
└── target
    └── x86_64-pc-windows-msvc
        └── release
            └── datadog-static-analyzer.exe

Whereas before, it was:

.
└── datadog-static-analyzer.exe

What is your solution?

Fix the invocation of 7z so it creates the archive with the exe at the root level.

You can see a successful run of this (and download the binaries and confirm a root level exe here: https://github.com/DataDog/datadog-static-analyzer/releases/tag/pre-release-110424-2)

Alternatives considered

What the reviewer should know

  • d73cdbc triggered a pre-release to test this only for Windows. It will be force-pushed away before merging.

@jasonforal jasonforal requested a review from a team as a code owner November 4, 2024 10:56
@jasonforal jasonforal requested review from dastrong and juli1 and removed request for dastrong November 4, 2024 10:56
@jasonforal jasonforal force-pushed the jf/STAL-3119 branch 3 times, most recently from 0473d82 to fdaf9b9 Compare November 4, 2024 11:32
@jasonforal jasonforal merged commit 3c839ad into main Nov 4, 2024
70 checks passed
@jasonforal jasonforal deleted the jf/STAL-3119 branch November 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants