Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STAL-3020] Support validation #553

Merged
merged 12 commits into from
Nov 13, 2024
Merged

[STAL-3020] Support validation #553

merged 12 commits into from
Nov 13, 2024

Conversation

juli1
Copy link
Collaborator

@juli1 juli1 commented Nov 5, 2024

What problem are you trying to solve?

We want to validate secrets

What is your solution?

  1. Support new secret rules formats with validation
  2. Build SDS rules with validation

Testing

Add unit. and integration test with validation (test only unvalidated secrets)

Validation

Configuration
=============
version                : 0.4.5
revision               : development
config method          : remote configuration
cores available        : 10
cores used             : 8
#static analysis rules : 58
#secrets rules loaded  : 21
source directory       : /var/folders/8v/d16566g17b91b7zq6t5wwp000000gn/T/tmp.qTPdPIU5sI/
subdirectories         :
output file            : /tmp/bahar.json
secrets enabled        : true
output format          : sarif
ignore paths           : **/node_modules/**/*,**/jspm_packages/**/*,**/.next/**/*,**/.vuepress/**/*,**/venv/**/*,**/__pycache__/**/*,**/_vendor/bundle/ruby/**/*,**/.vendor/bundle/ruby/**/*,**/.bundle/**/*,**/.gradle/**/*,**/TemporaryGeneratedFile_.*.cs,**/*.designer.cs,**/*.generated.cs,**/*.g.cs,**/*.g.i.cs
only paths             : all paths
ignore gitignore       : false
use debug              : false
use staging            : false
ignore gen files       : true
rules languages        : python
max file size          : 200 kb
Found 0 violation(s) in 0 file(s) using 0 rule(s) within 0 sec(s)
███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 6/6Found 4 secret(s) (including 1 valid) in 6 file(s) using 21 rule(s) within 0 sec(s)

@juli1 juli1 requested a review from a team as a code owner November 5, 2024 21:53
@juli1 juli1 requested a review from dastrong November 5, 2024 21:53
crates/cli/src/model/datadog_api.rs Outdated Show resolved Hide resolved
crates/cli/src/model/datadog_api.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Show resolved Hide resolved
crates/cli/src/model/datadog_api.rs Outdated Show resolved Hide resolved
crates/cli/src/model/datadog_api.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Outdated Show resolved Hide resolved
@jasonforal jasonforal removed the request for review from dastrong November 6, 2024 08:50
crates/cli/src/model/datadog_api.rs Outdated Show resolved Hide resolved
crates/secrets/src/model/secret_rule.rs Outdated Show resolved Hide resolved
crates/cli/src/datadog_utils.rs Outdated Show resolved Hide resolved
crates/cli/src/model/datadog_api.rs Outdated Show resolved Hide resolved
@juli1 juli1 merged commit 2d87ae5 into main Nov 13, 2024
70 checks passed
@juli1 juli1 deleted the juli1/STAL-3020-analyzer branch November 13, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants