Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K9VULN-2227] Add artifacts to SARIF output #568

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

jasonforal
Copy link
Collaborator

What problem are you trying to solve?

In order to add test file detection to the analyzer, we will be generating metadata about individual artifacts (in our case, only files). A way to do this within the SARIF spec is by adding the artifacts property to a SARIF run and then attaching a property bag to each artifact.

What is your solution?

  • Add artifacts to the SARIF output (associating tags via a property bag will come in a future PR).

Alternatives considered

What the reviewer should know

  • No integration tests are necessary -- the unit test covers the presence of the "artifacts" property.

@jasonforal jasonforal requested a review from amaanq December 10, 2024 16:31
@jasonforal jasonforal requested a review from a team as a code owner December 10, 2024 16:31
crates/cli/src/sarif/sarif_utils.rs Outdated Show resolved Hide resolved
crates/cli/src/sarif/sarif_utils.rs Outdated Show resolved Hide resolved
@jasonforal jasonforal merged commit ff977c7 into main Dec 10, 2024
71 checks passed
@jasonforal jasonforal deleted the jf/K9VULN-2227 branch December 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants