[branch-48] Fix duplicates on Join creation during physical planning #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiaCastaneda
force-pushed
the
lia/cherry-pick-duplicate-names-error-2
branch
from
6287611 to
ed6b3a5
Compare
LiaCastaneda
changed the title
LiaCastaneda
force-pushed
the
lia/cherry-pick-duplicate-names-error-2
branch
from
ed6b3a5 to
2825428
Compare
…ring physical planning (apache#16454) * Fix duplicates on Join creation during physcial planning * Add Substrait reproducer * Better error message & more doc * Handle case for right/left/full joins as well
LiaCastaneda
force-pushed
the
lia/cherry-pick-duplicate-names-error-2
branch
from
2825428 to
6971955
Compare
fmonjalet
approved these changes
Jul 7, 2025
fmonjalet
left a comment
fmonjalet
left a comment
There was a problem hiding this comment.
Works for me, you can also add -x to your cherry pick command to include the original commit ref (don't mind for this one)
gabotechs
approved these changes
Jul 7, 2025
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
lia.castaneda@datadoghq.com cancelled this merge request build since it was merged manually |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Author
|
/remove |
|
View all feedbacks in Devflow UI.
|
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: in_progress
labels
gabotechs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks the commit from Fix duplicate field name error in Join::try_new_with_project_input during physical planning