Merge pull request #1389 from DataDog/leo/varnishadm

[varnish] fix `varnishadm` subp call with sudo
DataDog · Feb 20, 2015 · 08e8986 · 08e8986
2 parents b5b95ad + 54a5387
commit 08e8986
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/checks.d/varnish.py b/checks.d/varnish.py
@@ -98,8 +98,7 @@ def check(self, instance):
         varnishadm_path = instance.get('varnishadm')
         if varnishadm_path:
             secretfile_path = instance.get('secretfile', '/etc/varnish/secret')
-            varnishadm_path = 'sudo %s' % varnishadm_path
-            cmd = [varnishadm_path, '-S', secretfile_path, 'debug.health']
+            cmd = ['sudo', varnishadm_path, '-S', secretfile_path, 'debug.health']
             proc = subprocess.Popen(cmd, stdout=subprocess.PIPE)
             output, _ = proc.communicate()
             if output: