[disk] disable all_partitions by default

Otherwise a lot of useless/temp partitions appear. See https://github.com/giampaolo/psutil/blob/58711c2db81d437fdcf5b8aedf68bfd00fc089fd/psutil/_pslinux.py#L651-L653
DataDog · Jun 16, 2015 · b71e8e5 · b71e8e5
1 parent 790f5e8
commit b71e8e5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/checks.d/disk.py b/checks.d/disk.py
@@ -50,7 +50,7 @@ def _load_conf(self, instance):
         self._tag_by_filesystem = _is_affirmative(
             instance.get('tag_by_filesystem', False))
         self._all_partitions = _is_affirmative(
-            instance.get('all_partitions', True))
+            instance.get('all_partitions', False))
 
         # FIXME: 6.x, drop use_mount option in datadog.conf
         self._load_legacy_option(instance, 'use_mount', False,

diff --git a/conf.d/disk.yaml.default b/conf.d/disk.yaml.default
@@ -24,6 +24,6 @@ instances:
     # tag_by_filesystem: no
     #
     # The (optional) all_partitions parameter will instruct the check to
-    # only get metrics for physical disks if set to no
-    # all_partitions: yes
+    # get metrics for all partitions (and not only physical disks)
+    # all_partitions: no
 
diff --git a/tests/checks/mock/test_disk.py b/tests/checks/mock/test_disk.py
@@ -180,7 +180,7 @@ def test_default_options(self):
         self.assertEqual(self.check._excluded_filesystems, [])
         self.assertEqual(self.check._excluded_disks, [])
         self.assertFalse(self.check._tag_by_filesystem)
-        self.assertTrue(self.check._all_partitions)
+        self.assertFalse(self.check._all_partitions)
         self.assertEqual(self.check._excluded_disk_re, re.compile('^$'))
 
     def test_ignore_empty_regex(self):