Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snmp] config option for non-increasing OID support #1231

Closed
sethrosenblum opened this issue Dec 4, 2014 · 1 comment · Fixed by #1281
Closed

[snmp] config option for non-increasing OID support #1231

sethrosenblum opened this issue Dec 4, 2014 · 1 comment · Fixed by #1281
Assignees
@LeoCavaille
Milestone
5.2.0

Comments

@sethrosenblum
Copy link
Contributor

If the snmp library we use encounters non-increasing oids it fails. This is to prevent from infinite loops during snmp walks.

http://pysnmp.sourceforge.net/faq.html#10

We could add a flag to the snmp config that would allow increasing oids for a given instance:

cls.cmd_generator = cmdgen.CommandGenerator()
cls.cmd_generator.ignoreNonIncreasingOid = True
sethrosenblum added a commit that referenced this issue Dec 5, 2014
@sethrosenblum
Allow configuring of SNMP to ignore non-increasing OIDs. Fixes #1231.
3e4aabb
@remh remh added this to the 5.2.0 milestone Dec 12, 2014
@LeoCavaille
Copy link
Member

@sethrosenblum any reason why not to merge your patch? Could you submit a PR if no 😉 !

@LeoCavaille LeoCavaille changed the title SNMP check should allow for config with non-increasing oid [snmp] config option for non-increasing OID support Jan 5, 2015
@sethrosenblum sethrosenblum mentioned this issue Jan 5, 2015
Merged
sethrosenblum added a commit that referenced this issue Jan 14, 2015
@sethrosenblum @LeoCavaille
Allow configuring of SNMP to ignore non-increasing OIDs. Fixes #1231.
1cbd33a
sethrosenblum added a commit that referenced this issue Jan 14, 2015
@sethrosenblum @LeoCavaille
Allow configuring of SNMP to ignore non-increasing OIDs. Fixes #1231.
4cc84b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeoCavaille LeoCavaille

Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

[snmp] configuration option to ignore non-increasing OIDs DataDog/dd-agent
3 participants
@remh @LeoCavaille @sethrosenblum