Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zookeeper] bytes_outstanding metric returns number of requests served by zk node #1383

Closed
handigarde opened this issue Feb 19, 2015 · 1 comment · Fixed by #1443
Closed

[zookeeper] bytes_outstanding metric returns number of requests served by zk node #1383

handigarde opened this issue Feb 19, 2015 · 1 comment · Fixed by #1443
Milestone
5.3.0

Comments

@handigarde
Copy link
Contributor

User checking through the ZooKeeper check noticed that the bytes_outsanding metric the DD agent is scrapping is not bytes, but rather the number of inflight requests currently being serviced by the ZK node.

https://github.com/apache/zookeeper/blob/ca480231e1bdcbe6beda9142766fc3caa2031cd8/src/java/main/org/apache/zookeeper/server/ServerStats.java#L104

https://github.com/apache/zookeeper/blob/ca480231e1bdcbe6beda9142766fc3caa2031cd8/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L740
@remh
Copy link

remh commented Feb 25, 2015

Thanks a lot @handigarde looks like you're right.

@remh remh added this to the 5.3.0 milestone Feb 25, 2015
remh pushed a commit that referenced this issue Mar 17, 2015
bytes_outstanding metric is misleading
f74256d 
This value is not a value in bytes.
Fix #1383

We should remove it in a major version of the agent but for now, let’s
add a new metric name for this value.
@remh remh mentioned this issue Mar 17, 2015
Merged
@jeffwidman jeffwidman mentioned this issue Nov 3, 2017
Closed
@masci masci mentioned this issue Oct 26, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

[Zookeeper check] bytes_outstanding metric is misleading DataDog/dd-agent
2 participants
@handigarde @remh