Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNI support for http_check missing. #1398

Closed
rmoriz opened this issue Feb 26, 2015 · 0 comments · Fixed by #1399
Closed

SNI support for http_check missing. #1398

rmoriz opened this issue Feb 26, 2015 · 0 comments · Fixed by #1399

Comments

@rmoriz
Copy link

rmoriz commented Feb 26, 2015

We've serveral SSL/TLS enabled vhosts with different domain names on one machine and IP address using SNI. However, it looks like http_check.py and the http lib it uses do not support SNI.
remh added a commit that referenced this issue Feb 26, 2015
@remh
Switch http libraries used in checks to requests
9ac5989 
Fixes

* Fix #1196
* Fix #1398

Along with the self contained agent (pyopenssl etc) it will support SNI.

See https://github.com/kennethreitz/requests/issues/749 for more
information
@remh remh mentioned this issue Feb 26, 2015
Merged
remh added a commit that referenced this issue Feb 27, 2015
@remh
Switch http libraries used in checks to requests
3c95374 
* Fix #1196
* Fix #1398

Along with the self contained agent (pyopenssl etc) it will support SNI.

See https://github.com/kennethreitz/requests/issues/749 for more information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch http libraries used in checks to requests DataDog/dd-agent
1 participant
@rmoriz