Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] support tagging for events #1421

Closed
robparrott opened this issue Mar 12, 2015 · 2 comments
Closed

[docker] support tagging for events #1421

robparrott opened this issue Mar 12, 2015 · 2 comments

Comments

@robparrott
Copy link

Despite the documentation, the docker agent module does not include tags when creating events:

https://github.com/DataDog/dd-agent/blob/master/checks.d/docker.py#L321-L328
@LeoCavaille
Copy link
Member

Hey @robparrott, thanks for opening this issue.
Can you:

  • indicate what you're referring to by the documentation?
  • tell us what kind of tags you'd like to see in docker events?

@LeoCavaille LeoCavaille changed the title Docker module does not support tagging events [docker] support tagging for events Mar 13, 2015
@remh remh added this to the To be determined milestone Mar 17, 2015
@ejholmes
Copy link
Contributor

👍 for this.

Events pertaining to a container should be tagged with the same tags that metrics include. This would probably require keeping an internal mapping of container id -> tags for every container and pruning the list when containers die.

Having this feature would be great since it's currently not possible to filter docker events by image_name or container_name (or any docker labels if you're setting collect_labels_as_tags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants