[emitter] Split check runs from main agent payload #3446
Merged
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's switch the milestone to 5.16. We actually need to do some changes in the backend to be ready for this. |
olivielpeau
approved these changes
Jul 28, 2017
There was a problem hiding this comment.
LGTM! 
This will conflict with #3454, I'll fix the conflicts on that PR once this is merged.
|
@remh We're planning to release 5.17.0 in about a week (feature freeze on Monday), are the backend changes related to this ready? |
|
Talked with @remh, this is ready for 5.17 (the related backend changes are ready). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extracts the check runs from the legacy payload and posts them to their API endpoint.
Motivation
This would help in the backend.
Testing Guidelines
Added a test on the split function but this will need to be well tested on staging