[collector] Only add service check fields if non-null #3487
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `api/v1/check_run` endpoint doesn't accept payloads with a `message` value of `null`, so avoid that. Do the same thing on the `tags` and `hostname` fields as it makes sense to be consistent.
olivielpeau
added a commit
that referenced
this pull request
Aug 22, 2017
The `api/v1/check_run` endpoint doesn't accept payloads with a `message` value of `null`, so avoid that. Do the same thing on the `tags` and `hostname` fields as it makes sense to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids
nullvalues on service check fields.Motivation
The
api/v1/check_runendpoint doesn't accept payloads with amessagevalue ofnull, so avoid that. #3446 was not working because of this.Do the same thing on the
tagsandhostnamefields as it makes sense to be consistent.cc @remh