Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn SSL certificate validation into an option of http_check.py #770

Closed
alq666 opened this issue Dec 19, 2013 · 2 comments · Fixed by #778
Closed

Turn SSL certificate validation into an option of http_check.py #770

alq666 opened this issue Dec 19, 2013 · 2 comments · Fixed by #778
Assignees
@alq666
Milestone
4.1.x

Comments

@alq666
Copy link
Member

alq666 commented Dec 19, 2013

  • Leave it to False by default
  • Make it a per-site option in the yaml file
  • Log a warning when it is set to False
@ghost ghost assigned alq666 Dec 23, 2013
alq666 added a commit that referenced this issue Dec 26, 2013
@alq666
Turn ssl validation of http_check into an option
27c081f 
Fixes #770.
Merge from master.
@alq666 alq666 mentioned this issue Dec 29, 2013
Merged
@alq666 alq666 closed this as completed Dec 30, 2013
@remh
Copy link
Contributor

remh commented Dec 30, 2013

Why should it be false by default ?

I think that the previous behavior was to validate certificates, so i think we should stick to the previous default behavior.

@ssbarnea
Copy link

In fact I think that the default is to disable the check with is also wrong. Also is documented wrongly in the example where it shows the non-default option commented. That's clearly counter-intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alq666 alq666

Labels
None yet
Projects
None yet
Milestone
4.1.x
Development

Successfully merging a pull request may close this issue.

Packaging clean-up + SSL warning in http_check DataDog/dd-agent
3 participants
@alq666 @ssbarnea @remh