Add a service check for Couchbase. #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbranagan
force-pushed
the
conor/couchbase-service-check
branch
from
7b16648 to
2495f34
Compare
|
Looks good, thanks! |
|
Yup. As the deb package and rpm packages bundle python 2.7 and the source installation script has always just been working with python2.6 we can be sure that agent > 5.0 only run on python 2.6 or 2.7. |
|
@conorbranagan could you rebase on master please? |
- With a test that should work without Couchbase running (testing failure) - Also cleaned up some pre-omnibus code checking the Python version.
conorbranagan
force-pushed
the
conor/couchbase-service-check
branch
from
2495f34 to
f0df22c
Compare
LeoCavaille
added a commit
that referenced
this pull request
Dec 18, 2014
Add a service check for Couchbase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failure)