[haproxy] use new test class #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
| @@ -119,6 +120,12 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| self.check = None | |||
|
|
|||
| # Helper function when testing rates | |||
| def run_check_twice(self, config, agent_config=None, mocks=None): | |||
| self.run_check(config, agent_config=None, mocks=None) | |||
There was a problem hiding this comment.
Here you should pass the options the user intended to use and not None.
self.run_check(config, agent_config, mocks)
There was a problem hiding this comment.
Yep, copy/paste error, thanks !
|
Nice cleanup 👍 |
- PEP8 and FLAKE8 cleaning in `haproxy.py` - use AgentCheckTest to test haproxy (rewrite old tests to have a 100% metrics coverage) - start/stop haproxy in `ci/haproxy.rb`, instead of inside the test itself - add a `run_check_twice` function inside `AgentCheckTest` to avoid code repetition when testing rates
degemer
force-pushed
the
quentin/test_haproxy
branch
from
d5c65b3 to
a369fe7
Compare
|
Thanks! |
LeoCavaille
added a commit
that referenced
this pull request
Mar 25, 2015
[haproxy] use new test class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haproxy.pymetrics coverage)
ci/haproxy.rb, instead of inside the testitself
run_check_twicefunction insideAgentCheckTestto avoid coderepetition when testing rates