[rabbitmq] Improve test suite and fix tagging #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* because we checked the tags only to be non-`None` we were creating empty tags like `rabbitmq_policy:` * adds some helper methods in `AgentCheckTest` to assert directly a service check by status like `assertServiceCheckCritical` without having to import `AgentCheck` just for that in the test file * add coverage report to ensure we cover 100% of the metrics output add TODO instead of commenting the missing metrics, maybe we can do that at some point but we would have to create a consumer and do some work to get these. For instance use the `pika` python module. * Bonus: some pep8-ing
53 tasks
|
|
||
| for data_line in data[:max_detailed]: | ||
| # We truncate the list of nodes/queues if it's above the limit | ||
| self._get_metrics(data_line, object_type) | ||
|
|
||
|
|
||
| def _get_metrics(self, data, object_type): | ||
| tags = [] | ||
| tag_list = TAGS_MAP[object_type] | ||
| for t in tag_list.keys(): |
There was a problem hiding this comment.
I know it's not your code but we shouldn't use
.keys()here
Thanks to @remh review.
|
Thanks @remh for catching that, will merge when tests have passed (apache being a known failure) |
LeoCavaille
added a commit
that referenced
this pull request
Mar 31, 2015
[rabbitmq] Improve test suite and fix tagging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonewe were creatingempty tags like
rabbitmq_policy:AgentCheckTestto assert directly aservice check by status like
assertServiceCheckCriticalwithouthaving to import
AgentCheckjust for that in the test fileadd TODO instead of commenting the missing metrics, maybe we can do
that at some point but we would have to create a consumer and do some
work to get these. For instance use the
pikapython module.