Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zk] CI + tests #1488

Merged
merged 1 commit into from
Apr 7, 2015
Merged

[zk] CI + tests #1488

merged 1 commit into from
Apr 7, 2015

Conversation

yannmh
Copy link
Member

@yannmh yannmh commented Mar 31, 2015

CI and tests

@yannmh yannmh self-assigned this Mar 31, 2015
@yannmh yannmh added this to the 5.3.0 milestone Mar 31, 2015
@yannmh yannmh force-pushed the yann/zookeeper-ci branch from 6d49180 to c453d1f Compare March 31, 2015 18:55
@yannmh yannmh changed the title [zk] enable ci [zk] CI + tests Mar 31, 2015
@degemer degemer mentioned this pull request Mar 31, 2015
Closed
53 tasks
@yannmh yannmh force-pushed the yann/zookeeper-ci branch 2 times, most recently from 6db8816 to dbd8cec Compare April 1, 2015 21:29
remh
remh reviewed Apr 3, 2015
View reviewed changes
tests/test_zookeeper.py

@attr(requires='zookeeper')
class ZooKeeperTestCase(AgentCheckTest):
CHECK_NAME = 'zk'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@remh remh assigned remh and unassigned yannmh Apr 3, 2015
@remh
Copy link
Contributor

remh commented Apr 3, 2015

Thanks @yannmh !
I made a few comments can you fix them when you have a chance please ?

@yannmh
Copy link
Member Author

yannmh commented Apr 3, 2015

Great, thanks @remh !

@LeoCavaille
Copy link
Member

@yannmh bumping this one.

@yannmh yannmh force-pushed the yann/zookeeper-ci branch from dbd8cec to 3e9b3ea Compare April 7, 2015 14:04
@yannmh
Copy link
Member Author

yannmh commented Apr 7, 2015

Fixed. Should be ready to merge 👍

@LeoCavaille
Copy link
Member

LGTM. Thanks!

LeoCavaille added a commit that referenced this pull request Apr 7, 2015
@LeoCavaille
Merge pull request #1488 from DataDog/yann/zookeeper-ci
39aaa22 
[zk] CI + tests
@LeoCavaille LeoCavaille merged commit 39aaa22 into master Apr 7, 2015
@LeoCavaille LeoCavaille deleted the yann/zookeeper-ci branch April 7, 2015 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remh remh

Labels
3 - Done
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yannmh @remh @LeoCavaille