[Memcache] Improve tests and bug fixes #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
| @@ -120,6 +120,12 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| self.check = None | |||
|
|
|||
| def reset(self): | |||
| self.check = None | |||
There was a problem hiding this comment.
@yannmh added force_reload in run_check could that be enough? Let's try to keep this class neat.
|
Nice cleanup! 👍 |
- 100% metrics and service check coverage - Add a default tag so that multi instances will work properly - Remove monkey patch as it’s not needed anymore (See comments about python-memcached version impacted here: d3bbd1ff561b3b2682ae79d308876 a4910f9ff3b ) - Flake 8 Also: - Add a helper in the AgentCheckTest class to determine if we’re running on travis or not
|
memcache tests succeded. I just fixed up your "Fix as per review" commit with the previous one to get a cleaner history 😉 |
LeoCavaille
added a commit
that referenced
this pull request
Apr 2, 2015
[Memcache] Improve tests and bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-memcached version impacted here:
d3bbd1ff561b3b2682ae79d308876
a4910f9ff3b )
Also:
running on travis or not